Update Env.php to prevent Undefined global variable $_ENV#83
Open
ggedde wants to merge 1 commit intojmespath:masterfrom
Open
Update Env.php to prevent Undefined global variable $_ENV#83ggedde wants to merge 1 commit intojmespath:masterfrom
ggedde wants to merge 1 commit intojmespath:masterfrom
Conversation
I have $_ENV disabled on my server as I only need environment variables accessible from getenv(). Unfortunately using array_key_exists() throws an error since $_ENV does not exist. So this commit resolves that.
Collaborator
|
This is somewhat unusual. Typically getenv is not a good idea because it's not thread-safe, and can leak values between concurrent invokes on php-fpm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have $_ENV disabled on my server as I only need environment variables accessible from getenv(). Unfortunately using array_key_exists() throws an error since $_ENV does not exist. So this commit resolves that.